|
From: | thomasmorley65 |
Subject: | Re: Add Changes entries for \temporary, \omit, \hide, \single, multiple tags (issue 8187044) |
Date: | Sat, 30 Mar 2013 19:25:04 +0000 |
Some nitpicks. Otherwise LGTM https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely#newcode73 Documentation/changes.tely:73: Two ways of letting graphical objects not appear in the PDF are What about the others: png, eps, svg? https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely#newcode78 Documentation/changes.tely:78: respectively. They can be given a music expression to tweak, or From description and example a user might expect that the following snippets are working: \relative c'' { <a e' \hide Accidental ais>1 } \relative c'' { <a e' \omit ais>1 } \relative c'' { <a e' \omit Accidental ais>1 } Perhaps inserting a link to LM or NR or wherever they are explained, would be sufficient. https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely#newcode94 Documentation/changes.tely:94: \override NoteHead.color #red c4 Seems you missed some "=" https://codereview.appspot.com/8187044/
[Prev in Thread] | Current Thread | [Next in Thread] |