Re: Format inserting-score-fragments snippet nicer in the wake of issue 3187 (issue 9705045)

[dak]

Reviewers: Graham Percival,

Message:
On 2013/06/06 21:26:28, Graham Percival wrote:
> I think the original version was more general,

No, it wasn't.  Not having a clue about the alignment of the staff
within the score containing the tuning, it centered the whole score, in
this case between the top of the staff and the lowest note.  If you use
the same code for different tunings (or use notes with stems, or a
treble clef), the staff will move vertically accordingly.  Centering the
score was probably the best one could do without knowing where the staff
was located within. But since the baseline is now (namely after issue
3187 has been tackled) exactly on the middle staff line (it was
previously at the bottom or top of the score bounding box, don't
remember which), it is easy to do better.  It turned out that putting
the middle staff line on the base line did not look good after the
preceding colon: it made more sense to shift the score up half a staff
space (half a colon height would probably have been even better, but
that's pretty much the same).

> but if it produces ugly output due to a bug then I guess I can't
complain about this change.

It produced output that really should have gotten additional manual
fine-tuning that would have required amending after any change in the
contents of the score.  In contrast, the current version is stable
vertically.  You can change the content of the score and the staff lines
will stay put.

Description:
Format inserting-score-fragments snippet nicer in the wake of issue 3187


Also
Run scripts/auxiliar/makelsr.py

Please review this at https://codereview.appspot.com/9705045/

Affected files:
  M  
Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
  A +  
Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly


Index:  
Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
diff --git  
a/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly  
b/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
index  
b531c4bf13b076541e42a247c06b8f8a71733170..388398c02d8fd948cb5c072498734972c45bc58c  
100644
---  
a/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
+++  
b/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
@@ -1,9 +1,10 @@
-%% DO NOT EDIT this file manually; it is automatically
-%% generated from LSR http://lsr.dsi.unimi.it
-%% Make any changes in LSR itself, or in Documentation/snippets/new/ ,
-%% and then run scripts/auxiliar/makelsr.py
-%%
-%% This file is in the public domain.
+% DO NOT EDIT this file manually; it is automatically
+% generated from Documentation/snippets/new
+% Make any changes in Documentation/snippets/new/
+% and then run scripts/auxiliar/makelsr.py
+%
+% This file is in the public domain.
+%% Note: this file works from version 2.17.15
 \version "2.17.15"

 \header {
@@ -25,14 +26,14 @@ tuning = \markup {
       \clef bass
       <c, g, d g>1
     }
-    \layout { ragged-right = ##t }
+    \layout { ragged-right = ##t  indent = 0\cm }
   }
 }

 \header {
   title = "Solo Cello Suites"
   subtitle = "Suite IV"
-  subsubtitle = \markup { Originalstimmung: \general-align #Y #CENTER  
\tuning }
+  subsubtitle = \markup { Originalstimmung: \raise #0.5 \tuning }
 }

 \layout { ragged-right = ##f }
Index:  
Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly
diff --git  
a/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly  
b/Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly
similarity index 63%
copy from  
Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
copy to  
Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly
index  
b531c4bf13b076541e42a247c06b8f8a71733170..09a13cf667425be3f015b1f8e3e59bbcf8975d20  
100644
---  
a/Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly
+++  
b/Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly
@@ -1,9 +1,3 @@
-%% DO NOT EDIT this file manually; it is automatically
-%% generated from LSR http://lsr.dsi.unimi.it
-%% Make any changes in LSR itself, or in Documentation/snippets/new/ ,
-%% and then run scripts/auxiliar/makelsr.py
-%%
-%% This file is in the public domain.
 \version "2.17.15"

 \header {
@@ -15,8 +9,7 @@ contains a @code{\\score} block instead of texts or marks.

 "
   doctitle = "Inserting score fragments above a staff as markups"
-} % begin verbatim
-
+}

 tuning = \markup {
   \score {
@@ -25,14 +18,14 @@ tuning = \markup {
       \clef bass
       <c, g, d g>1
     }
-    \layout { ragged-right = ##t }
+    \layout { ragged-right = ##t  indent = 0\cm }
   }
 }

 \header {
   title = "Solo Cello Suites"
   subtitle = "Suite IV"
-  subsubtitle = \markup { Originalstimmung: \general-align #Y #CENTER  
\tuning }
+  subsubtitle = \markup { Originalstimmung: \raise #0.5 \tuning }
 }

 \layout { ragged-right = ##f }