Re: Fixes bounding boxes for breves, improves longas (Issue 3480)(issue 12030043)

[Phil Holmes]

----- Original Message ----- 
From: <address@hidden>
To: <address@hidden>; <address@hidden>; <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Tuesday, July 30, 2013 1:41 PM
Subject: Re: Fixes bounding boxes for breves, improves longas (Issue 
3480)(issue 12030043)


> https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf
> File mf/feta-noteheads.mf (right):
>
> https://codereview.appspot.com/12030043/diff/1/mf/feta-noteheads.mf#newcode118
> mf/feta-noteheads.mf:118: staff_space# * quanted_line_length);
> Does that mean that the bounding box includes the whole stem of a longa
> in both up and down directions?  Or is this something else?  If it's
> something else, what is it that will reserve the space for the stem?
>
> https://codereview.appspot.com/12030043/


No - this patch increases the size of the bounding box to take account of 
the bars, but not the stem of the longa.  The other patch that's on Rietveld 
extends the bounding box asymmetrically to take account of the stem of the 
longa.

--
Phil Holmes