|
| From: | benko . pal |
| Subject: | Re: Issue 3560: Completion_heads_engraver with \scaleDurations (issue 14268043) |
| Date: | Fri, 25 Oct 2013 12:52:55 +0000 |
basically LGTM https://codereview.appspot.com/14268043/diff/9001/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right): https://codereview.appspot.com/14268043/diff/9001/lily/completion-note-heads-engraver.cc#newcode200 lily/completion-note-heads-engraver.cc:200: factor_ = robust_scm2rational (factor, 0); 1 would be a more robust default https://codereview.appspot.com/14268043/
| [Prev in Thread] | Current Thread | [Next in Thread] |