lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: let RhythmicStaff use default barline extent (issue 35060046)


From: janek . lilypond
Subject: Re: let RhythmicStaff use default barline extent (issue 35060046)
Date: Sun, 01 Dec 2013 12:28:13 +0000

Reviewers: Keith,

Message:
On 2013/11/30 05:56:50, Keith wrote:
Looks good.

Repeat bars look fine (as they do in Drum Staff).

The book by Kurt Stone happens to have some bar-lines in single-line
percussion
staves that are as tall as a 4/4 time-signature.  Other examples in
the same
book have short bar-lines like these here, and looking at some scores
the short
bar-lines are more common.

Thanks! I've added this as a comment in the commit message, so that
anyone curious about the background of our decision will have something
to look at.

best,
Janek

Description:
let RhythmicStaff use default barline extent

There is no reason to make barlines in RhythmicStaff special.
The purpose of the deleted code was probably to ensure that
the barlines were visible at all (despite the fact that there
is just one staffline in a RhythmicStaff).  However, currently
barline code takes care of this by default.

This makes barlines in DrumStaff and RhythmicStaff similar.

Please review this at https://codereview.appspot.com/35060046/

Affected files (+0, -1 lines):
  M ly/engraver-init.ly


Index: ly/engraver-init.ly
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index 9ff53bed6c80b93734dabfb0c7cee0278b74cd43..ff777875c646962d020341d35778db291dda23e1 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -169,7 +169,6 @@ contained staves are not connected vertically."
   \name RhythmicStaff
   \alias "Staff"

-  \override BarLine.bar-extent = #'(-2 . 2)
   \override VoltaBracket.staff-padding = #3
   \override StaffSymbol.line-count = #1






reply via email to

[Prev in Thread] Current Thread [Next in Thread]