[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)
From: |
janek . lilypond |
Subject: |
Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043) |
Date: |
Sat, 07 Dec 2013 17:04:00 +0000 |
There's one nitpick, other than that it can go. There are some things i
would do in another way, but there's no sense wasting time discussing
them. I'll just make a new patch if i'll have the time.
thanks, and i'm sorry that it took so long!
Janek
https://codereview.appspot.com/35310043/diff/1/lily/slur-configuration.cc
File lily/slur-configuration.cc (right):
https://codereview.appspot.com/35310043/diff/1/lily/slur-configuration.cc#newcode64
lily/slur-configuration.cc:64: :
state.parameters_.gap_to_staffline_outside_);
You forgot about staffline thickness:
mus = \relative c'' {
\override Slur.details.gap-to-staffline-inside = #0.05
\override Slur.details.gap-to-staffline-outside = #0.05
\slurUp
a2( a)
e1( a)
}
\markup \scale #'(3 . 3) {
\score {
\mus
\layout { }
}
}
will result in slurs touching stafflines.
https://codereview.appspot.com/35310043/
- Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043),
janek . lilypond <=