[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
splitting file movement and whitespace-only changes into separate commit
From: |
benko . pal |
Subject: |
splitting file movement and whitespace-only changes into separate commits (issue 42330044) |
Date: |
Sat, 14 Dec 2013 16:31:24 +0000 |
Reviewers: ,
Message:
continuation of
http://codereview.appspot.com/38530043
belonging to
http://code.google.com/p/lilypond/issues/detail?id=3705
if requested, I can either update dev/janek/metafont-cleanup or push as
a new branch.
Description:
splitting file movement and whitespace-only changes into separate
commits
the commits now read (in reverse chronological order):
unify formatting and indentation
----------------------------------------------------->8
include subfonts unconditionally
----------------------------------------------------->8
remove spurious else
----------------------------------------------------->8
make comments more uniform
----------------------------------------------------->8
factor out common inclusions and initializations
----------------------------------------------------->8
factor out autometric_parameter declarations
----------------------------------------------------->8
move brace-drawing procedure to separate file (and rename files)
----------------------------------------------------->8
rename feta-alphabet to feta-alphabet-generic
to conform to the convention
----------------------------------------------------->8
rename feta-generic to feta-other-generic; similarly parmesan-generic
these files are not for the whole font,
but just some glyphs that aren't in their own subfonts
----------------------------------------------------->8
remove feta-test-generic.mf and other testing files
they were just polluting the code
----------------------------------------------------->8
font: clean up staffline-display in testing mode
Previous testing code was a mix of hideous copy&paste with
non-obvious passing glyph outlines around, which attempted
to produce additional glyphs in testing mode, so that there
would be both on-staffline and on-staffspace variations.
That code was completely unreadable and unmaintainable.
Instead i've introduced a global variable that determines
how the stafflines will be printed relative to the glyphs.
To see alternative configuration, just change that value.
----------------------------------------------------->8
font: rename draw_staff to draw_staff_if_debugging
Previous name was confusing: the stafflines are actually
not drawn unless 'test' is set to non-zero value.
----------------------------------------------------->8
feta accidentals: split into several files
----------------------------------------------------->8
omit filename extension as in the rest of the file
Please review this at https://codereview.appspot.com/42330044/
Affected files (+1473, -2485 lines):
A mf/common-modules-and-initialization.mf
A mf/debugging-settings.mf
A mf/declare-autometric-parameters.mf
M mf/feta-accidentals.mf
A mf/feta-alphabet-generic.mf
D mf/feta-alphabet.mf
M mf/feta-alphabet11.mf
M mf/feta-alphabet13.mf
M mf/feta-alphabet14.mf
M mf/feta-alphabet16.mf
M mf/feta-alphabet18.mf
M mf/feta-alphabet20.mf
M mf/feta-alphabet23.mf
M mf/feta-alphabet26.mf
A mf/feta-arrow.mf
M mf/feta-braces-a.mf
M mf/feta-braces-b.mf
M mf/feta-braces-c.mf
M mf/feta-braces-d.mf
M mf/feta-braces-e.mf
M mf/feta-braces-f.mf
M mf/feta-braces-g.mf
A mf/feta-braces-generic.mf
M mf/feta-braces-h.mf
M mf/feta-braces-i.mf
M mf/feta-braces.mf
M mf/feta-clefs.mf
M mf/feta-flags-generic.mf
M mf/feta-flags11.mf
M mf/feta-flags13.mf
M mf/feta-flags14.mf
M mf/feta-flags16.mf
M mf/feta-flags18.mf
M mf/feta-flags20.mf
M mf/feta-flags23.mf
M mf/feta-flags26.mf
A mf/feta-flats.mf
D mf/feta-generic.mf
M mf/feta-macros.mf
A mf/feta-naturals.mf
M mf/feta-noteheads-generic.mf
M mf/feta-noteheads.mf
M mf/feta-noteheads11.mf
M mf/feta-noteheads13.mf
M mf/feta-noteheads14.mf
M mf/feta-noteheads16.mf
M mf/feta-noteheads18.mf
M mf/feta-noteheads20.mf
M mf/feta-noteheads23.mf
M mf/feta-noteheads26.mf
A mf/feta-other-generic.mf
A mf/feta-parenthesis.mf
M mf/feta-rests.mf
M mf/feta-scripts.mf
A mf/feta-sharps.mf
D mf/feta-test-generic.mf
D mf/feta-test11.mf
D mf/feta-test13.mf
D mf/feta-test16.mf
D mf/feta-test20.mf
D mf/feta-test23.mf
D mf/feta-test26.mf
M mf/feta-timesignatures.mf
M mf/feta11.mf
M mf/feta13.mf
M mf/feta14.mf
M mf/feta16.mf
M mf/feta18.mf
M mf/feta20.mf
M mf/feta23.mf
M mf/feta26.mf
M mf/parmesan-clefs.mf
D mf/parmesan-generic.mf
M mf/parmesan-noteheads-generic.mf
M mf/parmesan-noteheads11.mf
M mf/parmesan-noteheads13.mf
M mf/parmesan-noteheads14.mf
M mf/parmesan-noteheads16.mf
M mf/parmesan-noteheads18.mf
M mf/parmesan-noteheads20.mf
M mf/parmesan-noteheads23.mf
M mf/parmesan-noteheads26.mf
A mf/parmesan-other-generic.mf
M mf/parmesan11.mf
M mf/parmesan13.mf
M mf/parmesan14.mf
M mf/parmesan16.mf
M mf/parmesan18.mf
M mf/parmesan20.mf
M mf/parmesan23.mf
M mf/parmesan26.mf
- splitting file movement and whitespace-only changes into separate commits (issue 42330044),
benko . pal <=