lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 3718 in lilypond: Patch: Web: Reword contactUsAbout macro


From: Urs Liska
Subject: Re: Issue 3718 in lilypond: Patch: Web: Reword contactUsAbout macro
Date: Fri, 20 Dec 2013 11:15:54 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Am 20.12.2013 11:12, schrieb David Kastrup:
As the typical victims for pushers are often able to grant push access,
you'll probably not have to go through this very often before they beg
you to accept push access.

I think I will do that soon.
Some time in the past I would have considered it a hassle not to have push access. But now I'm feeling it's quite good to go through the review process for a few times before having push access :-)


>Or should I leave the branch open, create the patch set and send it to
>-devel?
After rebasing on current master, that's doable, too.  Again, if you
think that not all stages will necessarily compile, state that you want
this done as a merge commit.


Just as an opinion: Would you restrict this to be _compilable_ or should this also go for commits that aren't _useful_.

If I have more thorough rewrite of a page of the website (as the current "Features" patch), I will have a number of commits (e.g. "reorder items", "update section XX", "update section YY"). Although not having tested I assume the website is compilable after each of the commits, but these states don't make much sense.

Would you suggest to put such a series in a separate "thread" (by a merge no-ff) or not.
In my own work I would always do such stuff the no-ff merge commit way.

Urs




reply via email to

[Prev in Thread] Current Thread [Next in Thread]