[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue
From: |
marc |
Subject: |
Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043) |
Date: |
Sun, 05 Jan 2014 10:17:00 +0000 |
https://codereview.appspot.com/47840043/diff/20001/mf/feta-clefs.mf
File mf/feta-clefs.mf (right):
https://codereview.appspot.com/47840043/diff/20001/mf/feta-clefs.mf#newcode186
mf/feta-clefs.mf:186: reduced_ss# = staff_space# * reduction;
On 2014/01/05 04:51:22, lemzwerg wrote:
Uh, oh, the diff here on Rietveld is so big and unreadable because
you've
converted tabs to spaces, probably inadvertently. Please post another
revision
of your patch that fixes this, and ensure that your editor doesn't do
this
conversion automatically again.
I moved the definition of new_bulb to the beginning of the file. Diff
seems
to try to check differences paragraph-wise (i.e. splitted on empty
lines),
and this is where this ugly diff result comes from, I assume.
The last time I had tab/space conversion problems, the diff looked
completely
different, so I think this is not the case here.
https://codereview.appspot.com/47840043/
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), lemzwerg, 2014/01/04
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043),
marc <=
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), lemzwerg, 2014/01/06
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), Joram Berger, 2014/01/06
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), James, 2014/01/06
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), Ian Hulin, 2014/01/06
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), Marc Hohl, 2014/01/07
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), lemzwerg, 2014/01/18
- Re: Double G clef, tenor G clef, varpercussion clef and varC clef (issue 47840043), lemzwerg, 2014/01/18