[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix namespace issue with clang. (issue 84860044)
From: |
dschudy |
Subject: |
Fix namespace issue with clang. (issue 84860044) |
Date: |
Fri, 11 Apr 2014 06:48:40 +0000 |
LGTM. This works in clang 3.2, so it took me a while to figure out that
the problem was ambiguity with C++11 std::to_string, which is apparently
defined by default in 3.4.
It would be nice to avoid redefining std::to_string when it's available,
but AFAICT there isn't an easy way to detect it -- it can be present even
when __cplusplus < 201103, in compilers with partial C++11 support.
https://codereview.appspot.com/84860044/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Fix namespace issue with clang. (issue 84860044),
dschudy <=