[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by
|
From: |
marc |
|
Subject: |
Re: Doc: NR section 3.5.x MIDI file creation tidy up (issue 120480043 by address@hidden) |
|
Date: |
Sat, 27 Sep 2014 16:53:21 +0000 |
Great work! The MIDI stuff is better structured and well explained now -
just one nitpick, see below, otherwise LGTM!
https://codereview.appspot.com/120480043/diff/100001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/120480043/diff/100001/Documentation/notation/input.itely#newcode2747
Documentation/notation/input.itely:2747: @emph{two} @code{\score}
blocks; one for MIDI (with unfolded repeats)
this is a bit misleading IMHO:
You don't need two \score blocks when using \unfoldRepeats
but you rather need \unfoldRepeats when dealing with both printable
output and MIDI
https://codereview.appspot.com/120480043/