Re: Issue 4191: add an "\or" markup command (issue 169290045 by address@hidden)

[dak]

On 2014/11/12 06:40:45, dak wrote:

https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm
> File scm/define-markup-commands.scm (right):


https://codereview.appspot.com/169290045/diff/20001/scm/define-markup-commands.scm#newcode1183
> scm/define-markup-commands.scm:1183: (interpret-markup-list layout
props l))))
> I'd not do all of l here.  Try just (list (car l)) instead.  That way,
you don't
> evaluate all the rest of l unnecessarily.

> Either that, or evaluate anything anyway.  Much simpler, but probably
not in the
> spirit of "or".

Actually, if you want to go really nuts, instead of
interpret-markup-list you could use something akin to what
map-markup-commands does in order to throw yourself out of
interpretation once you have the first stencil.  Not sure it's worth the
trouble, but at least markups are already safe for throws when
interpreting.

https://codereview.appspot.com/169290045/