lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 4186: Remove the single-C time signature style (issue 186630043 by


From: nine . fierce . ballads
Subject: Issue 4186: Remove the single-C time signature style (issue 186630043 by address@hidden)
Date: Thu, 01 Jan 2015 21:19:13 +0000

Reviewers: ,

Description:
Issue 4186: Remove the single-C time signature style

Remove the single-C time signature style that was added in commit
40b0982cb4f00317c3d50c7f1d4e26fde912f3cd to address Issue 3286.

The later commit 145389636e81237d560aba4d04abcb89fa60cd9c allows
the user to define new time signature styles, which is a more
flexible solution.

Please review this at https://codereview.appspot.com/186630043/

Affected files (+0, -29 lines):
  D input/regression/time-signature-single-c.ly
  M scm/time-signature-settings.scm


Index: input/regression/time-signature-single-c.ly
diff --git a/input/regression/time-signature-single-c.ly b/input/regression/time-signature-single-c.ly
deleted file mode 100644
index 5e115e4070e6f2e11dece52717e6c1b9ca4c4867..0000000000000000000000000000000000000000
--- a/input/regression/time-signature-single-c.ly
+++ /dev/null
@@ -1,20 +0,0 @@
-\version "2.19.16"
-
-\header {
- texidoc = "The single-C time signature style prints a C for any time signature with 4 in the numerator and prints a cut-C for any time signature with 2 in the numerator."
-}
-
-\layout { indent = 0 }
-
-\new Staff {
-  \relative f' {
-    \override Staff.TimeSignature.style = #'single-C
-    \time 1/2 f2^"1/2"
-    \time 2/2 f2^"2/2" f
-    \time 2/1 f1^"2/1" f
-    \time 3/4 f4^"3/4" f f
-    \time 4/4 f4^"4/4" f f f
-    \time 4/2 f2^"4/2" f f f
-    \time 4/1 f1^"4/1" f f f
-  }
-}
Index: scm/time-signature-settings.scm
diff --git a/scm/time-signature-settings.scm b/scm/time-signature-settings.scm index bee620eb9fc7e1fe20adbf0a5e948d5bdc5aeb6a..f55c76c0b687e2d28c742c77508278b16d5253d0 100644
--- a/scm/time-signature-settings.scm
+++ b/scm/time-signature-settings.scm
@@ -394,15 +394,6 @@ a fresh copy of the list-head is made."
 (add-simple-time-signature-style 'C make-c-time-signature-markup)
 (add-simple-time-signature-style 'default make-c-time-signature-markup)

-(define-public (make-single-c-time-signature-markup fraction)
-  "Make markup for the `single-C' time signature style."
-  (let ((n (car fraction)))
-    (if (or (= n 2) (= n 4)) ; numerator only
-        (make-glyph-time-signature-markup 'C (cons n n))
-        (make-compound-meter-markup n))))
-
-(add-simple-time-signature-style 'single-C make-single-c-time-signature-markup)
-
 ;;;%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
;;; Measure length calculation of (possibly complex) compound time signatures






reply via email to

[Prev in Thread] Current Thread [Next in Thread]