lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enhancement: LilyPond-mode for packaging emacs 24 (issue 189520045 b


From: dak
Subject: Re: Enhancement: LilyPond-mode for packaging emacs 24 (issue 189520045 by address@hidden)
Date: Fri, 16 Jan 2015 09:36:06 +0000


https://codereview.appspot.com/189520045/diff/1/elisp/lilypond-mode.el
File elisp/lilypond-mode.el (right):

https://codereview.appspot.com/189520045/diff/1/elisp/lilypond-mode.el#newcode165
elisp/lilypond-mode.el:165: (setq currword (car co))
Is there a reason you untab everything here?  This is not the GNU
standard for Elisp, it is not the default, and it will lead to any
further editing reintroducing the tabs and consequently further muddying
the history.

Bulk changes of indentation are only done in separate commits in order
not to mask the actual changes, and they should be discussed/announced
prior to application.

https://codereview.appspot.com/189520045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]