Re: Issue 4275: Allow user-defined rest styles. (issue 200860043 by address@hidden)

[nine . fierce . ballads]

Thanks for taking a close look.  I will experiment with the
positioning-done callback.  I will also add a regtest based on your
custom stencil example in issue 4245.


https://codereview.appspot.com/200860043/diff/20001/input/regression/rest-dot-position.ly
File input/regression/rest-dot-position.ly (right):

https://codereview.appspot.com/200860043/diff/20001/input/regression/rest-dot-position.ly#newcode11
input/regression/rest-dot-position.ly:11:
On 2015/01/31 06:02:50, Keith wrote:
> Why not in rest.scm ?
> I guess you are going to personally tell everyone who has used the
mirrored-z
> rest how to add these lines to thier input files ...

Simply because I don't like "z" as a style name.  I just sent an email
to the users' list asking for suggestions.  If nothing better is
proposed in the next several days, I'll add a built-in style called "z".

https://codereview.appspot.com/200860043/diff/20001/lily/rest.cc
File lily/rest.cc (right):

https://codereview.appspot.com/200860043/diff/20001/lily/rest.cc#newcode166
lily/rest.cc:166: + offset);
On 2015/01/31 06:02:50, Keith wrote:
> I guess that get_position() could possibly trigger a full layout, but
I can't
> tell for sure without booting Linux to experiment.

I don't know what "trigger a full layout" means.

> I trust that you are certain there is a reason we need below to
carefully avoid
> calling is_ledgered().

Well, I believe there is a reason that it was carefully avoided in the
past, and I know that experimentally changing it to be less careful
caused differences in tests, but I can not say that I fully comprehend
why it should be avoided.

https://codereview.appspot.com/200860043/diff/20001/lily/rest.cc#newcode203
lily/rest.cc:203:
On 2015/01/31 06:02:50, Keith wrote:
> The comments depend on the meaning of the word 'pure' as used by a
subset of
> LilyPond programmers.  You could just say:
> // Get a stencil, but if 'pure'=true do so without testing if the rest
needs a
> ledger

If pure=true, do not cache the result in the stencil-pure property.
(This is because the CG says looking up a pure property should never
result in a call to set_property.)

https://codereview.appspot.com/200860043/diff/20001/ly/engraver-init.ly
File ly/engraver-init.ly (right):

https://codereview.appspot.com/200860043/diff/20001/ly/engraver-init.ly#newcode897
ly/engraver-init.ly:897: \hide Rest
On 2015/01/31 06:02:50, Keith wrote:
> %% Should probably change to the logical \omit Rest
> %%  but before 2015 omitted rests were allocated space,
> %%  so this \omit Rest  preserves former (maybe undesired) behavior

I'll do that, and I should probably open a ticket if this really was
undesired.

https://codereview.appspot.com/200860043/