Re: Doc Issue 4350: \compressFullBarRests needs a warning (issue 227470043 by address@hidden)

[tdanielsmusic]

Reviewers: Jean-Charles,


https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193
Documentation/learning/fundamental.itely:3193: r4 f8 a | cis4 f | e4 d |
On 2015/04/24 17:16:28, Jean-Charles wrote:
> maybe add a "R2*2" to show the expansion?

Thanks for looking.  I thought of doing what you suggest
and had even made the change, but then I realised that
the snippet was part of a longer narrative showing how
a score and parts was built up.  So it would have required
a rather more invasive change.  Instead, I gave the reference
to the section in the NR which does indeed give several
examples of consecutive MM rests.

Description:
Doc Issue 4350: \compressFullBarRests needs a warning

  The \compressFullBarRests predef, which simply sets
  skipBars true, can generate incorrectly set music if
  used carelessly.  The problem is that its action is
  not restricted to rests: it removes bar lines whenever
  a rest or a _note_ crosses a bar line.

  Add a warning to the NR and point to it from the LM.

  Use \compressFullBarRests in the LM example rather than
  explicitly setting skipBars, and show how the rests
  should be bracketed between \compressFullBarRests and
  \expandFullBarRests.

Please review this at https://codereview.appspot.com/227470043/

Affected files (+27, -6 lines):
  M Documentation/learning/fundamental.itely
  M Documentation/notation/rhythms.itely


Index: Documentation/learning/fundamental.itely
diff --git a/Documentation/learning/fundamental.itely  
b/Documentation/learning/fundamental.itely
index  
6aa80af8d344a81390f7089d5ac02668cca462ac..29f7280ac029354f5c672d2f460bf9ae2233e4c8  
100644
--- a/Documentation/learning/fundamental.itely
+++ b/Documentation/learning/fundamental.itely
@@ -3164,27 +3164,38 @@ takes address@hidden in 2/4 time
 R2*3
 @end example

-When printing the part, multi-rests
-must be condensed.  This is done by setting a run-time variable
+When printing the part, multi-rests must be condensed.  There is a
+pre-defined command to do this:

 @example
-\set Score.skipBars = ##t
+\compressFullBarRests
 @end example

 @noindent
 This command sets the property @code{skipBars} in the
address@hidden context to true (@code{##t}).  Prepending the rest and
-this option to the music above, leads to the following result
address@hidden context to true (@code{##t}).  A similar command:
+
address@hidden
+\expandFullBarRests
address@hidden example
+
+does the opposite.
+
+Full bar rests expressed with a multiplier and bracketed between these
+two commands are compressed:

 @lilypond[quote,ragged-right]
 \transpose f c' \relative c {
   \time 2/4
-  \set Score.skipBars = ##t
+  \compressFullBarRests
   R2*3 |
+  \expandFullBarRests
   r4 f8 a | cis4 f | e4 d |
 }
 @end lilypond

+For more details see @ruser{Full measure rests}.
+

 The score is made by combining all of the music together.  Assuming
 that the other voice is in @code{bassoonNotes} in the file
Index: Documentation/notation/rhythms.itely
diff --git a/Documentation/notation/rhythms.itely  
b/Documentation/notation/rhythms.itely
index  
f14e0dbd996297cd29f57386ff2113ed3ad59984..ee30ccef55b188f5d52df97d054a4c14582d5e50  
100644
--- a/Documentation/notation/rhythms.itely
+++ b/Documentation/notation/rhythms.itely
@@ -880,6 +880,13 @@ r1 | R1*17 | R1*4 |
 R2.*2 |
 @end lilypond

address@hidden action of @address@hidden is to remove
+bars and bar lines which contain no notes or rests other than a previous
+note or rest whose duration carries over one or more of the following
+bars.  Because it also applies to long notes it is safest to always
+bracket the full bar rests between @address@hidden and
address@hidden@bs{}expandFullBarRests} commands as shown above.}
+

 @cindex text on multi-measure rest
 @cindex multi-measure rest, attaching text
@@ -965,6 +972,9 @@ setting, resulting bar-check warnings may not be  
displayed.
 Music Glossary:
 @rglos{multi-measure rest}.

+Learning Manual
address@hidden and parts}.
+
 Notation Reference:
 @ref{Durations},
 @ref{Text},