[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove CR LF from snippets using makelsr (issue 238520043 by address
|
From: |
dak |
|
Subject: |
Re: Remove CR LF from snippets using makelsr (issue 238520043 by address@hidden) |
|
Date: |
Sun, 24 May 2015 14:52:52 +0000 |
https://codereview.appspot.com/238520043/diff/1/scripts/auxiliar/makelsr.py
File scripts/auxiliar/makelsr.py (right):
https://codereview.appspot.com/238520043/diff/1/scripts/auxiliar/makelsr.py#newcode254
scripts/auxiliar/makelsr.py:254: s = s.replace ("\r\n", "\n")
It would seem that this replacement should be done before other
line-related replacements. Basically, right after reading s. At least
I'm not sure that it does not affect the other replacements.
Most other replacements appear to be precompiled (look for
strip_white_spaces_re for an example). It may make sense doing that
here as well.
https://codereview.appspot.com/238520043/