lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 4433: chord step 14 should be flat by default (issue 253410043 by


From: nine . fierce . ballads
Subject: Issue 4433: chord step 14 should be flat by default (issue 253410043 by address@hidden)
Date: Fri, 24 Jul 2015 11:56:40 +0000

LGTM (just one entirely optional suggestion below)


https://codereview.appspot.com/253410043/diff/1/lily/parser.yy
File lily/parser.yy (right):

https://codereview.appspot.com/253410043/diff/1/lily/parser.yy#newcode4061
lily/parser.yy:4061: while (step < 1)
Can't this be done in O(1) with some formula containing a modulo?  (Yes,
I see it was this way before, but since you're working so close by...)

https://codereview.appspot.com/253410043/diff/1/lily/parser.yy#newcode4064
lily/parser.yy:4064: if (step % 7 == 0)
"I say not unto thee, Until seven times: but, Until seventy times
seven."  :-)

https://codereview.appspot.com/253410043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]