Re: Let \autochange accept optional arguments for the turning-point and clefs (issue 259080043 by address@hidden)

[nine . fierce . ballads]

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/keyboards.itely
File Documentation/notation/keyboards.itely (right):

https://codereview.appspot.com/259080043/diff/20001/Documentation/notation/keyboards.itely#newcode294
Documentation/notation/keyboards.itely:294: If the staves are not
instantiated explicitely other clefs may be used.
explicitly,
          ^
(correct spelling and insert comma)

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-change.ly
File input/regression/auto-change.ly (right):

https://codereview.appspot.com/259080043/diff/20001/input/regression/auto-change.ly#newcode10
input/regression/auto-change.ly:10: If the staves are not instantiated
explicitely, other clefs may be specified.
IMO the new cases covering \with {} deserve to be in a separate file.  I
probably would have made a separate file for the case covering the
specified switch point too.

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly#newcode204
ly/music-functions-init.ly:204: Setting clefs works only for not
explicitely instantiated staves.")
not explicitly -> implicitly

https://codereview.appspot.com/259080043/diff/20001/ly/music-functions-init.ly#newcode210
ly/music-functions-init.ly:210: \context Staff = "up" $clef-1
I don't understand why $ rather than #.  Is it my problem, or does it
deserve a comment?

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm
File scm/autochange.scm (right):

https://codereview.appspot.com/259080043/diff/20001/scm/autochange.scm#newcode36
scm/autochange.scm:36: (cond ((ly:pitch<? ref-pitch pitch)
would ly:pitch-diff simplify this?

https://codereview.appspot.com/259080043/