Re: Allure and git-cl troubleshooting

[Thomas Morley]

2015-11-02 16:40 GMT+01:00 Phil Holmes <address@hidden>:
> ----- Original Message ----- From: "Phil Holmes" <address@hidden>
> To: "David Kastrup" <address@hidden>
> Cc: "lilypond-devel" <address@hidden>; "Trevor Daniels"
> <address@hidden>
> Sent: Monday, November 02, 2015 1:41 PM
> Subject: Re: Allure and git-cl troubleshooting
>
>
>> ----- Original Message ----- From: "David Kastrup" <address@hidden>
>> To: "Phil Holmes" <address@hidden>
>> Cc: "Trevor Daniels" <address@hidden>; "Paul Morris"
>> <address@hidden>; "lilypond-devel" <address@hidden>
>> Sent: Sunday, November 01, 2015 6:06 PM
>> Subject: Re: Allure and git-cl troubleshooting
>>
>>
>>> "Phil Holmes" <address@hidden> writes:
>>>
>>>> Turns out it is nothing to do with Allura: it's the way Rietveld uses
>>>> Google for authentication.  See
>>>> https://developers.google.com/identity/protocols/AuthForInstalledApps.
>>>> Further
>>>> thanks to Google for this.
>>>>
>>>> Question is: should I look into how to fix it, or is there a way to
>>>> ask the Rietveld team to fix upload.py and we wait for them?
>>>
>>>
>>> I think they fixed it a long time ago but nobody bothered copying it
>>> into our git-cl copy yet.
>>>
>>> --
>>> David Kastrup
>>
>>
>>
>> Don't think it's a case of "nobody bothered", rather "nobody knew".  I'll
>> have a look see what has been done.
>>
>> --
>> Phil Holmes
>
>
>
> I've pushed an updated version to github.  Please all - pull this updated
> version of git-cl and let me know how you get on.
>
>
> --
> Phil Holmes



Could upload now.

Terminal output is different than before:
~/lilypond-git (dev/quarter-tone-tab)$ git cl upload origin/master
 Documentation/changes.tely                   | 18 ++++++++++++
 Documentation/notation/fretted-strings.itely | 38 +++++++++++++++++++++++++
 input/regression/tablature-micro-tone.ly     | 42 ++++++++++++++++++++++++++++
 ly/engraver-init.ly                          |  3 +-
 scm/translation-functions.scm                | 36 +++++++++++++++++++-----
 5 files changed, 129 insertions(+), 8 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

    https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser


(process:3169): GLib-CRITICAL **: g_slice_set_config: assertion
'sys_page_size == 0' failed
Issue created. URL: http://codereview.appspot.com/272320043
Uploading base file for Documentation/changes.tely
Uploading base file for scm/translation-functions.scm
Uploading base file for input/regression/tablature-micro-tone.ly
Uploading base file for Documentation/notation/fretted-strings.itely
Uploading base file for ly/engraver-init.ly
This has been identified with issue 4643.
Is this correct? [y/n (y)]y
Ticket 
https://sourceforge.net/rest/p/testlilyissues/issues/_discuss/thread/994f86c3/7eff/
updated
Tracker issue done: 4643

Pretty much as expected, I'd think.

This one doesn't belong to git-cl:
(process:3169): GLib-CRITICAL **: g_slice_set_config: assertion
'sys_page_size == 0' failed
I always get this, whenever starting firefox from terminal.

The issue changed to "patch new"
The owner wasn't updated. Though, I don't know if it should ...


Thanks a lot,
  Harm