Dont emit \space glyph as empty page number (issue 276570043 by address@hidden)

[pkx166h]

Reviewers: ,

Message:
Passes make, make check and a full make doc.

Description:
Dont emit \space glyph as empty page number

Werner L reported in 2012 that LP
emits a space glyph referencing
the century schoolbook font at the
top of every page.

If you use gs (old and current) or
pdfcrop to crop output with multiple
pages and print-page-number = ##f
there is excessive white space at the
top of even pages.

ghostscript should handle that better
but a recent gs bug report
http://bugs.ghostscript.com/show_bug.cgi?id=696445
was closed as "WONTFIX".

There is a workaround within lilypond:

\paper {
    [...]
    oddHeaderMarkup = \markup \null
    evenHeaderMarkup = \markup \null
}

Changing " " to "" cured the problem
and appears to have no negative side
effects. Bounding boxes are affected
by this patch certainly so will have
effects in situations where snippets
are used by other third party
programs.

Please review this at https://codereview.appspot.com/276570043/

Affected files (+2, -4 lines):
  M ly/titling-init.ly


Index: ly/titling-init.ly
diff --git a/ly/titling-init.ly b/ly/titling-init.ly
index  
f397ad6bd90177b34de35c2f28ba5d96d8ce15f6..12bfa4f34072e919b2a38b2e607b47f33bab1554  
100644
--- a/ly/titling-init.ly
+++ b/ly/titling-init.ly
@@ -149,9 +149,7 @@ book last one."

 oddHeaderMarkup = \markup
 \fill-line {
-  %% force the header to take some space, otherwise the
-  %% page layout becomes a complete mess.
-  " "
+  ""
   \on-the-fly #not-part-first-page \fromproperty #'header:instrument
   \on-the-fly #print-page-number-check-first \fromproperty  
#'page:page-number-string
 }
@@ -162,7 +160,7 @@ evenHeaderMarkup = \markup
 \fill-line {
   \on-the-fly #print-page-number-check-first \fromproperty  
#'page:page-number-string
   \on-the-fly #not-part-first-page \fromproperty #'header:instrument
-  " "
+  ""
 }

 oddFooterMarkup = \markup {