lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Embed LilyPond source files inside generated PDF (issue 225040043 by


From: dak
Subject: Re: Embed LilyPond source files inside generated PDF (issue 225040043 by address@hidden)
Date: Sun, 28 Feb 2016 14:09:51 +0000


https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc
File lily/sources.cc (right):

https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode93
lily/sources.cc:93: (SCM parser_smob),
Maybe make the parser_smob argument optional?  It can be deduced via the
%parser fluid in the same manner a number of other functions do.

https://codereview.appspot.com/225040043/diff/120001/lily/sources.cc#newcode107
lily/sources.cc:107: return scm_reverse (lst);
I'd use scm_reverse_x (lst, SCM_EOL) here since you built the list
completely yourself, so there is no point in copying it for reversal.

https://codereview.appspot.com/225040043/diff/120001/scm/framework-ps.scm
File scm/framework-ps.scm (right):

https://codereview.appspot.com/225040043/diff/120001/scm/framework-ps.scm#newcode504
scm/framework-ps.scm:504: (ps-quote
It's that simple?  Wow.

https://codereview.appspot.com/225040043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]