lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Avoid some C++ comparisons of SCM values (issue 296010043 by address


From: dak
Subject: Re: Avoid some C++ comparisons of SCM values (issue 296010043 by address@hidden)
Date: Wed, 04 May 2016 14:29:06 -0700


https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc
File lily/output-def-scheme.cc (right):

https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc#newcode104
lily/output-def-scheme.cc:104: if (td && scm_is_eq (key,
td->get_context_name ()));
Man, is this the obfuscated C context or what?  The semicolon at the end
of the if-condition is the deadly sin.

https://codereview.appspot.com/296010043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]