Re: Add halfopenvertical to script.scm (issue 297340043 by address@hidden)

[Carl . D . Sorensen]

Reviewers: thomasmorley651,

Message:
It seems to me that if we want to make this kind of a regtest we should
really be looking at all TextScripts that are supposed to be
articulations, and seeing if the articulations work.

The regtest you proposed looks at all the articulations we have defined,
and sees if they properly print out.  This regtest would not have caught
the error I made, because the problem was I didn't add it to the
articulation list.

I think the regtest you proposed has some potential value, but I don't
think it should be tied to this issue.

The challenge is that some of the feta font elements in the scripts.*
familiy are used as articulations, while others (e.g. caesura) are not.
And the ones not used as articulations are not included in script.scm by
choice.

Maybe we could add a field to the NR Appendix A.8 [1] that is the
articulation used for each of the scripts.  And for those that had no
entry it would say something like "Not used as articulation".

Thanks for the careful thought!

Carl

1.
http://lilypond.org/doc/v2.19/Documentation/notation/the-feta-font#script-glyphs

Description:
Add halfopenvertical to script.scm

Please review this at https://codereview.appspot.com/297340043/

Affected files (+26, -0 lines):
  A input/regression/halfopenvertical.ly
  M scm/script.scm


Index: input/regression/halfopenvertical.ly
diff --git a/input/regression/halfopenvertical.ly  
b/input/regression/halfopenvertical.ly
new file mode 100644
index  
0000000000000000000000000000000000000000..c0e0f03e31ae126913a35d00545eef2d60eeb394
--- /dev/null
+++ b/input/regression/halfopenvertical.ly
@@ -0,0 +1,19 @@
+\version "2.19.43"
+
+\header {
+
+  texidoc = "The halfopenvertical articulation is available."
+
+}
+#(define mydrums '(
+         (hihat         cross #f                 5)
+         (openhihat     cross "open"             5)
+         (closedhihat   cross "stopped"          5)
+         (halfopenhihat cross "halfopenvertical" 5)))
+
+\new DrumStaff <<
+  \set DrumStaff.drumStyleTable = #(alist->hash-table mydrums)
+
+  \drummode { hh4 hhc hho hhho }
+>>
+
Index: scm/script.scm
diff --git a/scm/script.scm b/scm/script.scm
index  
5d975fe0ec43a54b0217b003efc101f75315677b..c8eb8b39b9a9f415bdd93c55ab9ca8cdd76016d8  
100644
--- a/scm/script.scm
+++ b/scm/script.scm
@@ -110,6 +110,13 @@
         (script-stencil . (feta . ("halfopen" . "halfopen")))
         (direction . ,UP)))

+    ("halfopenvertical"
+     . (
+        (avoid-slur . outside)
+        (padding . 0.20)
+        (script-stencil . (feta .  
("halfopenvertical" . "halfopenvertical")))
+        (direction . ,UP)))
+

     ("ictus"
      . (