Re: Issue 4876/4: Enable fontname replacing in TrueType functions (issue 300490043 by address@hidden)

[trueroad]

Thank you for your comments.


https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode185
lily/open-type-font.cc:185: //  FreeType 2.6.2+ has been fixed this
issue.)
On 2016/06/26 04:56:16, lemzwerg wrote:
> // FreeType 2.6.2+ has this bug fixed.)

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode186
lily/open-type-font.cc:186: // So we need directly parsing 'CFF' table,
in this case.
On 2016/06/26 04:56:16, lemzwerg wrote:
> // So we need direct parsing of the 'CFF' table, in this case.

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode190
lily/open-type-font.cc:190:
On 2016/06/26 04:56:16, lemzwerg wrote:
> // See Adobe technote '5176.CFF.pdf', sections 2 and 5-7.

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode217
lily/open-type-font.cc:217: + off2 - 1));
On 2016/06/26 04:56:16, lemzwerg wrote:
> This code always gets the first name in the CFF's name index.  Is this
> sufficient?

I think it is sufficient.

Current LilyPond supports OpenType/CFF fonts (e.g. OTF and OTC).
Other CFF font file is not supported.

OpenType Specification ver. 1.7 says that
"The Name INDEX in the CFF must contain only one entry;"
https://www.microsoft.com/typography/otspec/cff.htm

Therefore, the CFF that is supported by LilyPond has only one name.

In addition, I've never seen the CFF that has multiple names.

https://codereview.appspot.com/300490043/