lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 4988 straight-flags partly wrong claculated (issue 307600043 by ad


From: thomasmorley65
Subject: Issue 4988 straight-flags partly wrong claculated (issue 307600043 by address@hidden)
Date: Tue, 25 Oct 2016 13:37:54 -0700

Reviewers: ,

Description:
Issue 4988 straight-flags partly wrong claculated

The angles for straight-flags at down- and up-pointing stems are now
accurately respected.
This will cause some slight changes in the reg-tests.

Please review this at https://codereview.appspot.com/307600043/

Affected files (+7, -4 lines):
  M scm/flag-styles.scm


Index: scm/flag-styles.scm
diff --git a/scm/flag-styles.scm b/scm/flag-styles.scm
index 2b52f44cb23516eb2ce7924dda97ac37b376231c..82a21be3035f4c14a7cb5591405c53f9b44f125a 100644
--- a/scm/flag-styles.scm
+++ b/scm/flag-styles.scm
@@ -90,10 +90,13 @@ All lengths are scaled according to the font size of the note."
            (thickness-offset (cons 0 (* -1 thickness dir)))
            (spacing (* -1 flag-spacing factor dir ))
(start (cons (- half-stem-thickness) (* half-stem-thickness dir)))
-           (points (list start
-                         flag-end
-                         (offset-add flag-end thickness-offset)
-                         (offset-add start thickness-offset)))
+           (raw-points
+             (list
+               '(0 . 0)
+               flag-end
+               (offset-add flag-end thickness-offset)
+               thickness-offset))
+ (points (map (lambda (coord) (offset-add coord start)) raw-points))
            (stencil (ly:round-filled-polygon points half-stem-thickness))
            ;; Log for 1/8 is 3, so we need to subtract 3
            (flag-stencil (buildflag stencil (- log 3) stencil spacing))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]