Re: Improve elbowed-hairpin (issue 324800043 by address@hidden)

[david . nalesnik]

LGTM.

I've pointed out two minor issues, but I don't believe they should hold
up the review process.

By the way, applying

\override Hairpin.style = #'dashed-line to the regtest
input/regression/ferneyhough-hairpins.ly looks great!


https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm#newcode1171
scm/output-lib.scm:1171: (if (not (pair? (cdr pts)))
Note that this will fail if pts is '().  Perhaps you should check the
length of pts in elbowed-hairpin -- there must be at least two pairs in
the pts alist for a viable line.

https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm#newcode1172
scm/output-lib.scm:1172: (apply ly:stencil-add empty-stencil ls)
Why not use reduce here.

https://codereview.appspot.com/324800043/