Re: Support for English note names in Arabic Music (issue 322510043 by address@hidden)

[pkx166h]

This fails on 'make' and I don't know why...

--snip--

Effective prefix:
"/home/james/lilypond-git/build/out/share/lilypond/current"
PATH="/home/james/lilypond-git/build/out/bin/../bin:/home/james/lilypond-git/build/out/bin:/home/james/lilypond-git/build/lily/out:/home/james/lilypond-git/build/scripts/build/out:/home/james/lilypond-git/build/scripts/out:/home/james/lilypond-git/build/lily/out:/home/james/lilypond-git/build/scripts/build/out:/home/james/lilypond-git/build/scripts/out:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/james/bin:/home/james/lilypond-git/build/out/bin::"
[]
Guile 1.8
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily-library.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/output-lib.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/markup-macros.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/parser-ly-from-scheme.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/file-cache.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-event-classes.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-music-callbacks.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-music-types.scm]
[/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scmBacktrace:
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
 658: 0* [for-each #<procedure ly:load #> #]
In unknown file:
   ?: 1* [ly:load "define-note-names.scm"]
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm:
 507: 2* (let* ((file-name (%search-load-path x))) (ly:debug "[~A"
file-name) ...)
 511: 3* [primitive-load-path
"/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm"]
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm:
  45: 4* (define-session-public language-pitch-names (quasiquote (# # #
# ...)))
  45: 5  (begin # #)
In unknown file:
   ?: 6* [add-session-variable language-pitch-names ...
In
/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm:
  46: 7*  (quasiquote ((nederlands # # ...) (catalan # # ...) (deutsch #
# ...) ...))
1207: 8*  [ly:make-pitch -1 6 ...

/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm:1207:25:
While evaluating arguments to ly:make-pitch in expression (ly:make-pitch
-1 6 ...):
/home/james/lilypond-git/build/out/share/lilypond/current/scm/define-note-names.scm:1207:25:
Unbound variable: SEVEN-HALF-SHARP

--snip--

I assumed 'unbound' meant a brace was missing or there was some other
inconsistency with that line or section, but I cannot see it.

Any help would be very much appreciated.

https://codereview.appspot.com/322510043/