[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses) (is
From: |
torsten . haemmerle |
Subject: |
issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses) (issue 341140043 by address@hidden) |
Date: |
Fri, 20 Apr 2018 15:52:53 -0700 |
Reviewers: ,
Message:
Please review...
Thanks
Torsten
Description:
issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses)
lily/stencil-integral.cc
function make_partial_ellipse_boxes:
Use correct scaling factors for x_rad and y_rad for an arbitrary
transformation matrix
This affects calculation of quantisation value
function make_round_filled_box_boxes:
(1) remove unintentional additional space between box and skyline
(2) In case of rounded corners (threshold: diameter > 0.5 staff spaces)
or rotation, a detailed skyline will be constructed.
Rotated straight lines are drawn using buildings.
Rounded corners built out of boxes (cf. ellipse).
(3) Draw simple single-box skyline for simple boxes (i.e. in most cases,
e.g. ledger lines).
Please review this at https://codereview.appspot.com/341140043/
Affected files (+145, -13 lines):
M Documentation/changes.tely
A input/regression/skyline-boxes-ellipses.ly
M lily/stencil-integral.cc
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- issue 5307: Skyline Refinements (Rounded Boxes and Rotated Ellipses) (issue 341140043 by address@hidden),
torsten . haemmerle <=