Re: issue 5312: Key cancellation glyph position inconsistent (issue 343020043 by address@hidden)

[torsten . haemmerle]

On 2018/04/24 17:59:31, Carl wrote:
> LGTM.  I am just a *little* bit concerned about having the dimensions
of the
> Emmentaler natural glyph hardcoded in the source, but we already have
magic
> numbers reflecting the characteristics of the Emmentaler glyphs.

> Maybe it would be good to put a FIXME in recognizing this fact.  Or
maybe we
> just go as-is.

Hi Carl,

The intervals are just *approximating* the outlines of a run-of-the mill
natural glyph. I even played around with the concept using squared
paper.
This approach more or less relies on the fact that the
square/parallelogram
part of a natural glyph will be one stave-space high independent of the
font
used, just like a notehead in *any* font will be one stave-space high.

Therefore, it will also work for Gonville, Bravura, all of Abraham's
fonts...
Funny enough, it works for the LilyJAZZ font, too, because even in this
pseudo
handwritten font the square/parallelogram part has the same (standard)
height.

All the best,
Torsten

https://codereview.appspot.com/343020043/