[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5335: Use covariant return types on virtual Grob::clone() (iss
|
From: |
dak |
|
Subject: |
Re: Issue 5335: Use covariant return types on virtual Grob::clone() (issue 341320043 by address@hidden) |
|
Date: |
Mon, 04 Jun 2018 00:00:58 -0700 |
At any rate:
LGTM
I think that covariant return types predate C++11, right?
https://codereview.appspot.com/341320043/diff/20001/lily/system.cc
File lily/system.cc (right):
https://codereview.appspot.com/341320043/diff/20001/lily/system.cc#newcode449
lily/system.cc:449: dynamic_cast<Paper_column *> (c[j])->set_system
(system);
Not really in the scope of this patch/issue any more, but shouldn't c be
a vector<Paper_column *> and conversely Column_x_position (the type of
breaking[].cols_) ?
https://codereview.appspot.com/341320043/
- Re: Issue 5335: Use covariant return types on virtual Grob::clone() (issue 341320043 by address@hidden),
dak <=