Re: Issue 5362: Generalize context searches (issue 344050043 by address@hidden)

[dak]

On 2018/07/01 18:17:16, dan_faithful.be wrote:
> > On Jul 1, 2018, at 13:14, mailto:address@hidden wrote:
> >
> > Something like
> > origin->warning (_f ("Cannot find or create context: %s",
> > ctx->identification ()))

> Meh.  Multiple callers would repeat the message “cannot find or create
context”
> which is part of what I was trying to avoid.  I wouldn’t stake this
whole patch
> on getting it my way, but let’s mull it over while I work on the other
> revisions.

We currently have

address@hidden:/usr/local/tmp/lilypond$ git grep "find or create" lily
lily/context.cc:      warning (_f ("cannot find or create new `%s'",
lily/context.cc:  warning (_f ("cannot find or create `%s' called `%s'",
address@hidden:/usr/local/tmp/lilypond$

That's not multiple callers.  It's two different messages for two
different situations.  Why would a sensible refactoring introduce more
callers?

https://codereview.appspot.com/344050043/