[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5380: Fix `make doc` with non-clean build directory (issue 355
From: |
trueroad |
Subject: |
Re: Issue 5380: Fix `make doc` with non-clean build directory (issue 355750043 by address@hidden) |
Date: |
Fri, 13 Jul 2018 20:11:05 -0700 |
Thank you for your reviewing.
https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py
File scripts/build/www_post.py (right):
https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py#newcode97
scripts/build/www_post.py:97: os.link (f, strip_file_name[t] (f))
On 2018/07/13 22:54:48, Dan Eble wrote:
This is not a reason to hold back the patch, but this would be easier
to read
and probably perform better if strip_file_name[t] (f) were called once
instead
of three times. Otherwise, LGTM.
Done.
https://codereview.appspot.com/355750043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Issue 5380: Fix `make doc` with non-clean build directory (issue 355750043 by address@hidden),
trueroad <=