lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by add


From: dak
Subject: Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by address@hidden)
Date: Sat, 14 Jul 2018 00:43:14 -0700


https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make
File make/lilypond-book-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33
make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
This appears to change the output name after the fact.  It would still
create the output under the final name and when
a) some parallel Make goes looking for it, it will find it existing and
new
b) the script aborts while the file is still there
the problem, if any, would likely persist, possibly with a smaller time
window for causing trouble.

I think that any solution predicated on USE_EXTRACTPDFMARK would require
an if/then/else construct rather than an if/then construct in order not
to have this kind of race condition built-in by producing a file with
the final name, then doing additional actions on it.

https://codereview.appspot.com/357760043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]