[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Documentation: elaborate NR `custom percussion’ section (issue 55065
From: |
v . villenave |
Subject: |
Re: Documentation: elaborate NR `custom percussion’ section (issue 550650043 by address@hidden) |
Date: |
Mon, 13 May 2019 22:30:13 -0700 |
Reviewers: lemzwerg,
Message:
On 2019/04/26 17:13:12, lemzwerg wrote:
LGTM, thanks!
Thanks Werner, pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=bc46cc1fef7eecd0a64ac60223d40e98d79c9958
I think this sentence should end with `... be set to', dropping the
word `use'.
I’m not sure what the LilyPond doc guidelines are with regard to
dangling prepositions :-)
I’ve turned it into "… to which the property may be set".
Thanks again!
V.
Description:
Documentation: elaborate NR `custom percussion’ section
This patch adds a substantial amount of information to
NR 2.5.1.6 "Custom percussion staves", with examples
inspired by LSR #1033 and index entries for previously
undocumented variables and properties.
Accordingly, that snippet is no longer relevant in
the snippets list (it has been untagged as `docs’
in the LSR and should therefore not be brought back
by next makelsr update).
Please review this at https://codereview.appspot.com/550650043/
Affected files (+119, -159 lines):
M Documentation/notation/percussion.itely
D
Documentation/snippets/customize-drumpitchnames,-drumstyletable-and-drumpitchtable-in-layout-and-midi.ly
M Documentation/snippets/midi.snippet-list
M Documentation/snippets/percussion.snippet-list
M Documentation/snippets/pitches.snippet-list
M Documentation/snippets/specific-notation.snippet-list
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Documentation: elaborate NR `custom percussion’ section (issue 550650043 by address@hidden),
v . villenave <=