[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043
From: |
lemzwerg |
Subject: |
Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043 by address@hidden) |
Date: |
Fri, 31 May 2019 00:05:12 -0700 |
LGTM, but some comments. Thanks for working on this!
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74
Documentation/notation/world.itely:74: Western staff notes are still
used, but with special accidentals unique
unique → uniquely
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode78
Documentation/notation/world.itely:78: Other, related, init files are
also available; @file{hel-arabic.ly} and
Other, related, init files → Other, related init files
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode438
Documentation/notation/world.itely:438: @q{group} of maqams than
individual key signatures for each maqam
than → instead of
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode439
Documentation/notation/world.itely:439: seperately.
seperately → separately
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode505
Documentation/notation/world.itely:505: of a tone, from which are
constructed the melodic forms known as
from which the melodic forms ... are constructed.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode521
Documentation/notation/world.itely:521: the basis of pitch on 1/9-tone
divisions means makamlar employ a
means → means that
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode522
Documentation/notation/world.itely:522: completely different set of
intervals from Western scales and modes:
from → compared to
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode560
Documentation/notation/world.itely:560: The correct accidentals koma
flat (@var{b1}) and koma sharp (@code{f4}),
accidentals, ... (...), ...
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode591
Documentation/notation/world.itely:591: contains information in English
regarding Turkish makam including 2 CDs.
2 → two
https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly
File Documentation/snippets/new/turkish-makam-example.ly (right):
https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly#newcode7
Documentation/snippets/new/turkish-makam-example.ly:7: Here is a
template that also uses the start of a well known Turkish
Here is a template that also uses... → This template uses...
well known → well-known
https://codereview.appspot.com/550780043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043 by address@hidden),
lemzwerg <=