[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 5561/5562: slurs work without NoteHead stencil (issue 54697004
From: |
nine . fierce . ballads |
Subject: |
Re: Issue 5561/5562: slurs work without NoteHead stencil (issue 546970043 by address@hidden) |
Date: |
Tue, 01 Oct 2019 05:42:55 -0700 |
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode352
lily/slur-scoring.cc:352: if (!state.configurations_.size ())
It's not necessary to change this, but I encourage you to cultivate a
habit of using empty() in cases like this. empty() is a safer default
because not all containers have an O(1) size(). empty() is also more
readable, IMO.
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode551
lily/slur-scoring.cc:551: if (isinf (x) || isnan (x))
https://en.cppreference.com/w/cpp/numeric/math/isfinite
https://codereview.appspot.com/546970043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Issue 5561/5562: slurs work without NoteHead stencil (issue 546970043 by address@hidden),
nine . fierce . ballads <=