lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git-cl upload and existing sf issues


From: Dan Eble
Subject: Re: git-cl upload and existing sf issues
Date: Sat, 2 Nov 2019 15:36:05 -0400

On Nov 2, 2019, at 12:35, Dan Eble <address@hidden> wrote:
> 
>> when uploading a first patch set, git-cl asks for a sourceforge issue 
>> number. If a new issue is created, everything is fine but when you choose an 
>> existing issue, there is some 404 error and the Rietveld link is not added 
>> to the sf issue—resulting in a missing Rietveld link on 
>> www.philholmes.net/lilypond/allura/ Does anybody know why that is happening?
> 
> I'll investigate.  Don't subscribe to this ticket unless you want to be 
> interrupted frequently. :)
> 
> https://sourceforge.net/p/testlilyissues/issues/5591/

Here's the fix.  I'll close the LilyPond ticket after it's pulled.

    https://github.com/gperciva/git-cl/pull/5

During testing, I noticed that http://www.philholmes.net/lilypond/allura/ 
presents the link for the first review rather than the latter review. I don't 
think that's desirable, but it's a separate issue.
— 
Dan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]