|
| From: | nine . fierce . ballads |
| Subject: | Re: Make Pitch::to_string() more robust (issue 581580043 by address@hidden) |
| Date: | Sat, 01 Feb 2020 13:19:46 -0800 |
I approve of your use of braces for even single-statement blocks. https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc File lily/pitch.cc (right): https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc#newcode162 lily/pitch.cc:162: if (qt < int (sizeof (accname) / sizeof (accname[0]))) seems like you shouldn't need to cast it to int anymore aside from that, LGTM https://codereview.appspot.com/581580043/
| [Prev in Thread] | Current Thread | [Next in Thread] |