lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by ad


From: jonas . hahnfeld
Subject: Re: lilypond-book: Rewrite processing of snippets (issue 555220043 by address@hidden)
Date: Sun, 02 Feb 2020 07:33:05 -0800

On 2020/02/02 13:26:04, hahnjo wrote:
> On 2020/02/02 13:21:58, Dan Eble wrote:
> > On 2020/02/02 09:52:37, hahnjo wrote:
> > >
> >
>
https://codereview.appspot.com/555220043/diff/553480046/scripts/lilypond-book.py#newcode432
> > > scripts/lilypond-book.py:432: snippet_names_file =
'snippet-names-%s.ly' %
> > > checksum
> > > On 2020/02/01 16:54:40, Dan Eble wrote:
> > > > It's strange that this is named *.ly but does not contain ly
code.  That's
> > not
> > > > your problem, though.
> > > 
> > > True. It's now relatively simple to change, what would you prefer?
> > 
> > I'd probably have chosen txt.
> 
> Ok, will do.

Meh: I did the change and it works, but subprocess_system in
python/lilylib.py will still output the .ly name. As this file doesn't
exist anymore, it will just make investigations in case of an error more
difficult. I propose to table that change for now, ok?

https://codereview.appspot.com/555220043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]