[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Make all int -> Real casts explicit (issue 563460043 by address@hidd
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: Make all int -> Real casts explicit (issue 563460043 by address@hidden) |
|
Date: |
Sun, 02 Feb 2020 10:44:51 -0800 |
LGTM
https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-problem.cc#newcode739
lily/page-layout-problem.cc:739: = overflow / static_cast<Real>
(space_count - 2);
This isn't an issue with this change, but does anyone see whether
something prevents division by zero here? It isn't immediately obvious
to me.
https://codereview.appspot.com/563460043/
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Make all int -> Real casts explicit (issue 563460043 by address@hidden),
nine . fierce . ballads <=