[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: musicxml2ly: portugues notenames and quarternotes in español (issue
From: |
hanwenn |
Subject: |
Re: musicxml2ly: portugues notenames and quarternotes in español (issue 571630043 by address@hidden) |
Date: |
Sat, 15 Feb 2020 05:11:46 -0800 |
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:29:01, dak wrote:
> On 2020/02/15 12:19:54, hanwenn wrote:
> > português
>
> I don't think it makes sense to use anything here that doesn't match
the
> notename language defined in scm/define-note-names.scm . There is not
even an
> alias português there.
add this as a coment to the map.
https://codereview.appspot.com/571630043/