[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Issue 5773: Quarter Tones for all Languages incl. MusicXML import (issue
From: |
lemzwerg |
Subject: |
Issue 5773: Quarter Tones for all Languages incl. MusicXML import (issue 577520043 by address@hidden) |
Date: |
Wed, 19 Feb 2020 00:05:57 -0800 |
LGTM, thanks!
https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py
File python/musicexp.py (left):
https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py#oldcode365
python/musicexp.py:365: "nederlands": pitch_nederlands,
You are sorting the entries alphabetically except for Dutch. Is there a
reason for this?
https://codereview.appspot.com/577520043/diff/555310043/scm/define-note-names.scm
File scm/define-note-names.scm (right):
https://codereview.appspot.com/577520043/diff/555310043/scm/define-note-names.scm#newcode1416
scm/define-note-names.scm:1416: '((català catalan)(español
espanol)(português portugues)))
I would use spaces between ')('.
https://codereview.appspot.com/577520043/
- Issue 5773: Quarter Tones for all Languages incl. MusicXML import (issue 577520043 by address@hidden),
lemzwerg <=