[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Implement Grob::event_cause, Grob::ultimate_event_cause (issue 55950
From: |
nine . fierce . ballads |
Subject: |
Re: Implement Grob::event_cause, Grob::ultimate_event_cause (issue 559500043 by address@hidden) |
Date: |
Thu, 20 Feb 2020 16:13:25 -0800 |
LGTM
https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc
File lily/grob.cc (right):
https://codereview.appspot.com/559500043/diff/559510043/lily/grob.cc#newcode733
lily/grob.cc:733: while (unsmob<Grob> (cause))
I appreciate that issuing warnings is not performance-sensitive, and
that you simply transplanted this code, but what do you think about
avoiding repeating the unsmob, to set a good example? Something like
...
while (const Grob *g = unsmob<Grob> (cause))
{
cause = g->get_property ("cause");
}
https://codereview.appspot.com/559500043/