Unable to run make on older releases, while doing bug-reseach

[Thomas Morley]

Hi,

I'm currently trying to hunt down a possible bug (I wrote possible,
because I may very well ne intended behaviour. I don't know yet)
Using our prereleased installers I found it happened between 2.19.25
and 2.19.26.

Then I switched to git, in order to identify the patch which causes
the changed behaviour.

Alas, I'm not able to run 'make' successfully on any old release or inbetween.

I do (always with guile1):

 2053  rm -fr build/
 2054  git checkout release/2.19.25-1
 2055  mkdir -p build/
 2056  cd build/
 2057  ../configure
 2058  make -j3 CPU_COUNT=3

I always get:

In file included from /home/hermann/lilypond-git/lily/include/smobs.hh:367:0,
                 from /home/hermann/lilypond-git/lily/include/input.hh:24,
                 from /home/hermann/lilypond-git/lily/include/translator.hh:26,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:24,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/home/hermann/lilypond-git/lily/include/smobs.tcc: In instantiation of
'static void Smob_base<Super>::init() [with Super =
Callback_wrapper]':
/home/hermann/lilypond-git/lily/include/smobs.tcc:111:10:   required
from 'Scm_init Smob_base<Callback_wrapper>::scm_init_'
/home/hermann/lilypond-git/lily/include/smobs.hh:162:35:   required
from 'static scm_t_bits Smob_base<Super>::smob_tag() [with Super =
Callback_wrapper; scm_t_bits = long unsigned int]'
/home/hermann/lilypond-git/lily/include/smobs.tcc:58:3:   required
from 'static scm_unused_struct* Smob_base<Super>::register_ptr(Super*)
[with Super = Callback_wrapper; SCM = scm_unused_struct*]'
/home/hermann/lilypond-git/lily/include/smobs.hh:277:43:   required
from 'scm_unused_struct* Simple_smob<Super>::smobbed_copy() const
[with Super = Callback_wrapper; SCM = scm_unused_struct*]'
/home/hermann/lilypond-git/lily/include/listener.hh:196:64:   required
from 'static scm_unused_struct* Callback_wrapper::make_smob() [with T
= Metronome_mark_engraver; Arg = Stream_event*; void (T::*
callback)(Arg) = &Metronome_mark_engraver::listen_tempo_change; SCM =
scm_unused_struct*]'
/home/hermann/lilypond-git/lily/metronome-engraver.cc:64:1:   required from here
/home/hermann/lilypond-git/lily/include/smobs.tcc:143:37: error:
invalid conversion from 'int' to 'const char*' [-fpermissive]
       SCM subr = scm_c_define_gsubr (Super::type_p_name_, 1, 0, 0,
                  ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                      (scm_t_subr) smob_p);
                                      ~~~~~~~~~~~~~~~~~~~~
In file included from /usr/local/include/libguile.h:52:0,
                 from /home/hermann/lilypond-git/lily/include/lily-guile.hh:27,
                 from /home/hermann/lilypond-git/lily/include/grob-info.hh:23,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:23,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/usr/local/include/libguile/gsubr.h:47:13: note:   initializing
argument 1 of 'scm_unused_struct* scm_c_define_gsubr(const char*, int,
int, int, scm_unused_struct* (*)())'
 SCM_API SCM scm_c_define_gsubr (const char *name,
             ^~~~~~~~~~~~~~~~~~
In file included from /home/hermann/lilypond-git/lily/include/smobs.hh:367:0,
                 from /home/hermann/lilypond-git/lily/include/input.hh:24,
                 from /home/hermann/lilypond-git/lily/include/translator.hh:26,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:24,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/home/hermann/lilypond-git/lily/include/smobs.tcc:147:37: error:
invalid initialization of reference of type 'const string& {aka const
std::__cxx11::basic_string<char>&}' from expression of type 'const
int'
       ly_add_function_documentation (subr, Super::type_p_name_, "(SCM x)",
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                      fundoc);
                                      ~~~~~~~
In file included from
/home/hermann/lilypond-git/lily/include/lily-guile.hh:39:0,
                 from /home/hermann/lilypond-git/lily/include/grob-info.hh:23,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:23,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/home/hermann/lilypond-git/lily/include/lily-guile-macros.hh:142:6:
note: in passing argument 2 of 'void
ly_add_function_documentation(SCM, const string&, const string&, const
string&)'
 void ly_add_function_documentation (SCM proc, const string &fname,
const string &varlist, const string &doc);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/hermann/lilypond-git/lily/include/smobs.hh:367:0,
                 from /home/hermann/lilypond-git/lily/include/input.hh:24,
                 from /home/hermann/lilypond-git/lily/include/translator.hh:26,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:24,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/home/hermann/lilypond-git/lily/include/smobs.tcc:149:20: error:
invalid conversion from 'int' to 'const char*' [-fpermissive]
       scm_c_export (Super::type_p_name_, NULL);
       ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/local/include/libguile.h:65:0,
                 from /home/hermann/lilypond-git/lily/include/lily-guile.hh:27,
                 from /home/hermann/lilypond-git/lily/include/grob-info.hh:23,
                 from /home/hermann/lilypond-git/lily/include/engraver.hh:23,
                 from /home/hermann/lilypond-git/lily/metronome-engraver.cc:23:
/usr/local/include/libguile/modules.h:90:14: note:   initializing
argument 1 of 'void scm_c_export(const char*, ...)'
 SCM_API void scm_c_export (const char *name, ...);
              ^~~~~~~~~~~~
/home/hermann/lilypond-git/stepmake/stepmake/c++-rules.make:4: recipe
for target 'out/metronome-engraver.o' failed
make[1]: *** [out/metronome-engraver.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/hermann/lilypond-git/build/lily'


Same for 2.19.26 and 2.19.27 etc

Am I doing something wrong?


Thanks,
  Harm