[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix most encoding problems with Guile 2.x (issue 555420043 by addres
|
From: |
hanwenn |
|
Subject: |
Re: Fix most encoding problems with Guile 2.x (issue 555420043 by address@hidden) |
|
Date: |
Sat, 07 Mar 2020 15:15:09 -0800 |
LGTM
maybe add a TODO for the clumsy thing.
https://codereview.appspot.com/555420043/diff/549710049/lily/text-interface.cc
File lily/text-interface.cc (right):
https://codereview.appspot.com/555420043/diff/549710049/lily/text-interface.cc#newcode70
lily/text-interface.cc:70: SCM ligature = ly_assoc_get (substr,
replacement_alist, SCM_BOOL_F);
this whole thing is a bit clumsy. Couldnt we do
for k, v in replacement-alist
str = re.sub(k, v, str)
(python code, but you get the idea.)
https://codereview.appspot.com/555420043/