[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix output-distance tests (issue 569540043 by address@hidden)
|
From: |
lemzwerg |
|
Subject: |
Re: Fix output-distance tests (issue 569540043 by address@hidden) |
|
Date: |
Sat, 14 Mar 2020 14:58:51 -0700 |
Just skimming the code: LGTM
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
https://codereview.appspot.com/569540043/diff/555440061/scripts/build/output-distance.py#newcode66
scripts/build/output-distance.py:66: # explicitly use bash, so we don't
get dash on Ubuntu.
This needs an update of `STEPMAKE_INIT` in `aclocal.m4`. Right now,
AFAICS, `bash` is optional, and `configure` falls back to whatever is
given in the `SHELL` environment variable.
https://codereview.appspot.com/569540043/
- Re: Fix output-distance tests (issue 569540043 by address@hidden),
lemzwerg <=
Re: Fix output-distance tests (issue 569540043 by address@hidden), lemzwerg, 2020/03/15
Re: Fix output-distance tests (issue 569540043 by address@hidden), hanwenn, 2020/03/21