[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: flower: Get rid of libc-extension (issue 553740043 by address@hidden
|
From: |
hanwenn |
|
Subject: |
Re: flower: Get rid of libc-extension (issue 553740043 by address@hidden) |
|
Date: |
Tue, 17 Mar 2020 14:27:52 -0700 |
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
File input/regression/tie-single-manual.ly (right):
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
input/regression/tie-single-manual.ly:19: \override Tie.staff-position =
#-7.4
On 2020/03/17 21:06:42, hahnjo wrote:
> I'm not really happy about tweaking this test like this. It relies on
rounding
> halfway always up (my_round) instead of away from zero (std::round). I
think
> this is a coincidence, but if we want to retain this I need to go
through all
> replacements of my_round -> std::round and check if the argument could
be
> negative...
couldn't you inline my_round into the call site that needs this and add
a comment? The change otherwise risks breaking user tweaks, which we
should avoid if we can.
https://codereview.appspot.com/553740043/