|
| From: | jonas . hahnfeld |
| Subject: | Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by address@hidden) |
| Date: | Fri, 20 Mar 2020 06:01:47 -0700 |
The changes largely LGTM and I've verified that it finally works on my system. https://codereview.appspot.com/553700043/diff/577680043/mf/invoke-mf2pt1.sh File mf/invoke-mf2pt1.sh (right): https://codereview.appspot.com/553700043/diff/577680043/mf/invoke-mf2pt1.sh#newcode19 mf/invoke-mf2pt1.sh:19: # which no longer dump a .mem file You might want to delete this comment as we're not doing this anymore. https://codereview.appspot.com/553700043/diff/577680043/mf/invoke-mf2pt1.sh#newcode31 mf/invoke-mf2pt1.sh:31: --name=$name $src The last two lines are still indented with tabs, please cleanup. https://codereview.appspot.com/553700043/
| [Prev in Thread] | Current Thread | [Next in Thread] |