[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Inline executable-* stepmake templates in lily/GNUmakefile (issue 577690
From: |
lemzwerg |
Subject: |
Inline executable-* stepmake templates in lily/GNUmakefile (issue 577690043 by address@hidden) |
Date: |
Fri, 20 Mar 2020 22:53:15 -0700 |
>From visual checking I'm not sure whether your changes work as
expected...
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile
File lily/GNUmakefile (right):
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15
lily/GNUmakefile:15: LOADLIBES = $(FLOWER_LIB) $(CONFIG_LIBS)
What's the reason this isn't called `LOADLIBS`?
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode18
lily/GNUmakefile:18: EXECUTABLES = $(notdir $(EXECUTABLE))
This is a funny name, too. AFAICS, this is just a single name, right?
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode28
lily/GNUmakefile:28: $(foreach a, $(EXECUTABLES), \
Since `EXECUTABLES` is a single name, we don't need a loop.
And what happened with `SEXECUTABLES`?
https://codereview.appspot.com/577690043/
- Inline executable-* stepmake templates in lily/GNUmakefile (issue 577690043 by address@hidden),
lemzwerg <=